-
Notifications
You must be signed in to change notification settings - Fork 34
Extend 52N11/17 with message #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
||
== Status description | ||
error: procedure exception - generic topology procedure error. An unexpected error has occurred. Please refer to the server's debug log for more information. | ||
error: procedure exception - generic topology procedure error. An unexpected error has occurred: `{ <<msg>> }` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @gfx54b. Can we also add examples for both? See 22N71, 22N69, 22NAB, 42I64, and many more for inspiration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added an example - are we good to go ahead? I don't want to merge the core DB PR, before this is ready to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, only the full stop is missing in the message. See below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The full stop is tricky. Some of the msg
will already contain a full stop, some not, so I am a bit reluctant to put it into the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, you can add it to the status description.
=== xref:errors/gql-errors/52N11.adoc[52N11] | ||
|
||
Status description:: error: procedure exception - generic topology procedure error. An unexpected error has occurred. Please refer to the server's debug log for more information. | ||
Status description:: error: procedure exception - generic topology procedure error. An unexpected error has occurred: `{ <<msg>> }` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is autogenerated. You don't need to update it. I'll take care of it before I merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from my comment on the example
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can merge your PR into the code base. The only thing missing is the full stop at the end of the message. I am not sure if it should be part of the message or part of the status description.
I'll take care of this one after we publish 2025.10. Could you also add an example to 52N17?
|
||
== Status description | ||
error: procedure exception - generic topology procedure error. An unexpected error has occurred. Please refer to the server's debug log for more information. | ||
error: procedure exception - generic topology procedure error. An unexpected error has occurred: `{ <<msg>> }` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, only the full stop is missing in the message. See below.
This PR includes documentation updates Updated pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll add labels later and regenerate the index file.
No description provided.